Revert BlobSidecarsByRoot/Range version to v1
#14785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
update-blob-rpc-topics
branch
3 times, most recently
from
596c9ee to
e9e09ad
Compare
nalepae
reviewed
Jan 9, 2025
| @@ -47,8 +47,8 @@ func (s *Service) rpcHandlerByTopicFromFork(forkIndex int) (map[string]rpcHandle | |||
| p2p.RPCBlocksByRootTopicV2: s.beaconBlocksRootRPCHandler, | |||
| p2p.RPCPingTopicV1: s.pingHandler, | |||
| p2p.RPCMetaDataTopicV2: s.metaDataHandler, | |||
| p2p.RPCBlobSidecarsByRootTopicV2: s.blobSidecarByRootRPCHandler, // Modified in Electra | |||
| p2p.RPCBlobSidecarsByRangeTopicV2: s.blobSidecarsByRangeRPCHandler, // Modified in Electra | |||
| p2p.RPCBlobSidecarsByRootTopicV1: s.blobSidecarByRootRPCHandler, // Modified in Electra | |||
There was a problem hiding this comment.
So it's not modified in electra anymore right? (the comment)
There was a problem hiding this comment.
It is modified in electra, but it's reusing the same handler now, if the time/fork is after electra, we apply a different max blobs per request limit
There was a problem hiding this comment.
OK I see your point.
I added this commit to clarify the situation.
Let me copy here the commit message:
RPC handler comments: Use "Added", "Modified" and "Upgraded".
- Added: No message with this message name was previously existing.
- Upgraded: A message with this message name was existing in the previous fork, but the schema version is upgraded in the current fork.
- Modified: The couple message name, schema version is the same than in the previous fork, but the implementation of the handler is modified in the current fork.
e9e09ad to
ecee70d
Compare
- Added: No message with this message name was previously existing. - Upgraded: A message with this message name was existing in the previous fork, but the schema version is upgraded in the current fork. - Modified: The couple message name, schema version is the same than in the previous fork, but the implementation of the handler is modified in the current fork.
terencechain
force-pushed
the
update-blob-rpc-topics
branch
from
7f5d9e8 to
9688b90
Compare
james-prysm
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ethereum/consensus-specs#4077